[docs-infra] Move BrandingCssVarsProvider to _app.js #47721
Draft
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
the
scope: docs-infra
Janpot
changed the title
Netlify deploy previewhttps://deploy-preview-47721--material-ui.netlify.app/ Bundle size report
|
Member
As far as I know, we can't do this change because we need docs/pages/_app.js to be barebone so when we create paygrounds we see default behaviors, e.g. theme of our components. There is probably a root cause that we need to fix for our users too anyway? |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Member
Author
|
yeah, change of tac. Exporting a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dav-is This should fix your theming issue in the cookie banner (still has transparent background here, but I believe it comes from the themed Paper)
TODO