encode unknown protocol addresses as strings#18
Open
gaboose wants to merge 1 commit intomultiformats:masterfrom
Open
encode unknown protocol addresses as strings#18gaboose wants to merge 1 commit intomultiformats:masterfrom
gaboose wants to merge 1 commit intomultiformats:masterfrom
Conversation
Member
|
we'd have to length prefix them, see how i proposed unix recently |
marten-seemann
pushed a commit
to marten-seemann/go-multiaddr
that referenced
this pull request
Feb 25, 2021
replace gx instructions with note about gomod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can add new protocols from outside of this library with a line like
But it fails when I call
NewMultiaddr("/dns/google.com"), because it doesn't know how to encode "google.com". What if you encode unknown protocol addresses of variable length as bare strings?This change makes this library work.