-
-
Notifications
You must be signed in to change notification settings - Fork 4
⬆️ Update runners and prek checks
#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughUpdated GitHub Actions runners and test matrix (ubuntu-latest → ubuntu-slim; macOS 14 → macOS 15; Windows 2022 → Windows 2025), reworked Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.pre-commit-config.yaml:
- Around line 129-140: Add an explicit `priority: 2` entry to the mypy hook
block (the hook with repo "https://github.com/pre-commit/mirrors-mypy" and id
"mypy") so it is treated as a final pass consistent with other final checks;
update the existing mypy hook configuration to include the priority field at the
same indentation level as `rev` and `hooks`.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.pre-commit-config.yaml:
- Around line 47-55: The exclude regex for the disallow-caps hook is using
unescaped dots which match any character; update the exclude value for the hook
with id "disallow-caps" so filenames are matched precisely by escaping literal
dots (e.g., escape ".pre-commit-config.yaml" and the ".png" extension) in the
exclude pattern field to prevent accidental broad matches while keeping the
original alternation logic.
- Around line 24-29: Hooks with the same priority can run concurrently and cause
race edits; update the hook priorities so lightweight fixers run before
formatters: keep check-merge-conflict at priority 0, set end-of-file-fixer and
trailing-whitespace to priority 1, bump prettier and ruff-format to priority 2
(and any dependent checks to 3+), ensuring the hook IDs end-of-file-fixer,
trailing-whitespace, prettier, and ruff-format are reordered/assigned these
priority values so fixers run sequentially before formatters.
Description
This PR updates the CI to use
macos-15instead ofmacos-14andwindows-2025instead ofwindows-2022. It furthermore updates.pre-commit-config.ymlto make use ofprek's priority feature.Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.