Skip to content

⬆️ Update prek checks#317

Merged
denialhaag merged 4 commits intomainfrom
prek
Feb 4, 2026
Merged

⬆️ Update prek checks#317
denialhaag merged 4 commits intomainfrom
prek

Conversation

@denialhaag
Copy link
Member

@denialhaag denialhaag commented Feb 4, 2026

Description

This PR updates .pre-commit-config.yml to make use of prek's priority feature. Furthermore, it removes the extensive Python tests as the used matrix now largely overlaps with the default one, adding no substantive value.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag requested a review from burgholzer February 4, 2026 17:05
@denialhaag denialhaag self-assigned this Feb 4, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file pre-commit Any updates related to pre-commit labels Feb 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Optimized CI by removing an extensive test job, consolidating required checks, and switching several runners to a slimmer image for faster, leaner builds.
    • Enhanced pre-commit configuration with prioritized execution tiers, reordered and replaced hooks, and added modern formatting/linting/type-check tools for quicker feedback.
    • Updated tooling config to ignore legacy rST checks (PC170).

Walkthrough

Removed the python-tests-extensive CI job, switched several GitHub Actions runners from ubuntu-latest to ubuntu-slim, rewrote .pre-commit-config.yaml into prioritized hook tiers, and added PC170 to pyproject.toml's repo-review ignore list.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/ci.yml
Removed python-tests-extensive; updated required-checks-pass to run on ubuntu-slim; removed python-tests-extensive from needs and allowed-skips logic; final skipped jobs now include only python-tests,python-coverage,python-linter.
Runner updates
.github/workflows/release-drafter.yml, .github/workflows/templating.yml
Changed runs-on from ubuntu-latestubuntu-slim for release-drafter and templating jobs.
Pre-commit overhaul
.pre-commit-config.yaml
Major rewrite: introduced priority tiers (0–3); removed multiple legacy hooks; added many new hooks/repos (validate-pyproject, check-jsonschema, license-tools, uv-lock, bibtex-tidy, typos, sp-repo-review, prettier, ruff hooks, blacken-docs, ty-check, etc.); reorganized execution order and patterns.
Project config
pyproject.toml
Added PC170 to [tool.repo-review] ignore list (rST validation excluded).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • burgholzer
  • aaronleesander

Poem

🐰 I hopped through workflows, tidy and trim,
Removed a bulky test and made runners slim,
Hooks now queue in ordered delight,
I nibble lint and sleep by night ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and doesn't clearly describe the main changes; 'Update prek checks' lacks specificity about what was actually changed in the PR. Make the title more specific, such as 'Restructure pre-commit config with priority levels and remove extensive Python tests' to clearly convey the main changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description covers the main changes and most checklist items are appropriately marked, but several sections are crossed out without explanation of why they don't apply.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@denialhaag denialhaag merged commit b95ff2c into main Feb 4, 2026
16 checks passed
@denialhaag denialhaag deleted the prek branch February 4, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pre-commit Any updates related to pre-commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants