Skip to content

Fix #1123: make compile_snippets fails #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattha wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #1123: make compile_snippets fails #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dda5c2
Remove compilation of missing snippets
May 19, 2023
32c295a
Remove compilation of intermediate snippet
May 19, 2023
ceb0c19
Ignore warnings for unused variables in compiled snippets
May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tool/bin/compile_snippets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ var _chapterTags = <String, List<String>>{
"closure-op",
"disassemble-closure",
"interpret-closure",
"runtime-error-function",
"interpret",
"upvalue-struct",
"resolve-upvalue-recurse",
Expand Down Expand Up @@ -275,18 +274,8 @@ var _chapterTags = <String, List<String>>{
"Optimization": [
"initial-index",
"next-index",
"adjust-alloc",
"adjust-init",
"re-hash",
"adjust-free",
"table-set-grow",
"init-capacity-mask",
"add-all-loop",
"find-string-index",
"find-string-next",
"mark-table",
"remove-white",
"free-table",
"define-nan-boxing",
"end-values-equal",
],
Expand Down
1 change: 1 addition & 0 deletions util/c.make
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ CFLAGS += -Wall -Wextra -Werror -Wno-unused-parameter
# are functions that aren't used yet.
ifeq ($(SNIPPET),true)
CFLAGS += -Wno-unused-function
CFLAGS += -Wno-unused-but-set-variable
endif

# Mode configuration.
Expand Down