Skip to content

vgmdb_importer: split multiple catalog numbers #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y-young wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −2
Open

vgmdb_importer: split multiple catalog numbers #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions vgmdb_importer.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// @name Import VGMdb releases into MusicBrainz
// @namespace https://github.com/murdos/musicbrainz-userscripts/
// @description One-click importing of releases from vgmdb.net into MusicBrainz
// @version 2021.11.12.1
// @version 2022.4.29.1
// @downloadURL https://raw.githubusercontent.com/murdos/musicbrainz-userscripts/master/vgmdb_importer.user.js
// @updateURL https://raw.githubusercontent.com/murdos/musicbrainz-userscripts/master/vgmdb_importer.user.js
// @include /^https://vgmdb.net/(album|artist|org)/\d+/
Expand Down Expand Up @@ -41,7 +41,7 @@ function parseApi(apiResponse) {
year: releaseDate.year,
month: releaseDate.month,
day: releaseDate.day,
labels: [{ name: mapLabel(apiDict.organizations), catno: apiDict.catalog }],
labels: mapCatNo(apiDict.catalog, mapLabel(apiDict.organizations)),
barcode: apiDict.barcode,
urls: mapUrls(apiDict.vgmdb_link, apiDict.stores, apiDict.websites),
discs: mapDiscs(apiDict.discs, apiDict.media_format),
Expand Down Expand Up @@ -116,6 +116,31 @@ function mapLabel(organizations) {
}
}

/*
* Returns a list of catalog numbers.
* "N/A" -> []
* "ABCD-12345" -> [{ catno: "ABCD-12345", name }]
* "ABCD-12345~6" -> [{ catno: "ABCD-12345", name }, { catno: "ABCD-12346", name }]
* "ABCD-59~60" -> [{ catno: "ABCD-59", name }, { catno: "ABCD-60", name }]
*/
function mapCatNo(catNoStr, name) {
if (catNoStr === 'N/A') {
return [];
}
const parts = catNoStr.split('~');
const first = parts[0];
const catNos = [{ name, catno: first }];
const endStr = parts[1];
if (endStr) {
const end = parseInt(endStr);
const start = parseInt(first.slice(0 - endStr.length));
for (let i = start + 1; i <= end; ++i) {
catNos.push({ name, catno: first.slice(0, 0 - i.toString().length) + i.toString() });
}
}
return catNos;
}

/*
* Returns a list of MusicBrainz URLs based on the websites, stores and
* vgmdb_link values of the VGMdb API.
Expand Down