Skip to content

#166: Added support for the interface name in the config file#167

Merged
glaslos merged 8 commits intomushorg:mainfrom
RemZapCypher:eth0change
Feb 18, 2025
Merged

#166: Added support for the interface name in the config file#167
glaslos merged 8 commits intomushorg:mainfrom
RemZapCypher:eth0change

Conversation

@RemZapCypher
Copy link
Contributor

@RemZapCypher RemZapCypher commented Jan 29, 2025

Hey @glaslos,

Reffering to issue #166
I've made the necessary changes including adding new field to the configuration file for specifying the interface name.
Here’s how you can use the command:

sudo bin/server -i <interface name>

Example use case: sudo bin/server -i wlan0

By default, it will use eth0.

Additionally, I've included instructions for installing and running the project on Fedora. Since the bin/server command requires sudo privileges, I’ve also tried upgrading the README.md file to reflect these changes accordingly.

I would greatly appreciate your feedback on any changes or further modifications needed, I will be glad to do so!
Thank you,
Tank0nf.

@RemZapCypher RemZapCypher changed the title Added support for the interface name in the config file #166 #166: Added support for the interface name in the config file Jan 29, 2025
@RemZapCypher
Copy link
Contributor Author

Hello @glaslos,

Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project.

Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them.

Thanks again,
Tank0nf.

@RemZapCypher
Copy link
Contributor Author

Hello @glaslos,

Thank you for your feedback! I’ve made the necessary changes and am looking forward to contributing further to this project.

Please feel free to let me know if any additional adjustments are needed, I’d be happy to make them.

Thanks again,
Tank0nf.

@RemZapCypher
Copy link
Contributor Author

Hi @glaslos,
I have made the necessary changes, let me know if their is any more issue.
Thank you,
Tank0nf.

@glaslos
Copy link
Member

glaslos commented Feb 1, 2025

Now the last change missing is in the Makefile

@RemZapCypher
Copy link
Contributor Author

Hi @glaslos ,
I’ve made the necessary updates to the Makefile. Could you please review it and let me know if any further adjustments are needed?

Thank you,
Tank0nf

@RemZapCypher
Copy link
Contributor Author

Hi @glaslos
I have added an if statement to check for the interface details, please let me know if their is any other changes necessary.
Please let me know if their is any further changes.
Thank you,
Tank0nf.

@RemZapCypher
Copy link
Contributor Author

Hi @glaslos,
I have removed the config file thing and just reverted to

run: build
	sudo bin/server

If their is any further changes please let me know. I would be glad to follow through!
Thank you,
Tank0nf.

Copy link
Member

@glaslos glaslos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@glaslos glaslos merged commit dd187cb into mushorg:main Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants