Contravariant Msg type in Dispatchable and LocalActorRef

[le0-0]

Makes LocalActorRef and Dispatchable contravariant.

Description

The type of the protocol field of Dispatchable was changed to a type that TypeScript recognizes as contravariant. This field doesn't seem to be used for anything else beside coaxing the type system. Please deny the PR if this assumption is wrong.

Fixing this surfaced an error related to the fact that StatelessActorProps was not exactly assignable to ActorProps, even though it probably should be. I fixed this as well.

Some changes to the types of dispatch and query functions were also necessary for them to work with new behavior of Dispatchable and LocalActorRef.

Related Issue

Fixes #147

Motivation and Context

The error, as outlined in the #147, causes the type system to disallow certain assigning statements that should be allowed and vice versa.

How Has This Been Tested?

• Wrote a new unit test in actor.test.ts that creates a scenario where the contravariance of LocalActorRef is put to the test.
  • It makes use of // ts-expect-error
  • Is part of the npm run typecheck, not npm run test
• Wrote a new unit test suite – functions.test.ts – for dispatch and query, only testing types.
  • It makes use of // ts-expect-error
  • Is part of the npm run typecheck, not npm run test
• Ran npm run test in @nact/core
• Ran npm run typecheck in @nact/core

Screenshots (if appropriate):

The new test case I wrote went from this:

to this:

There's also more test cases in functions.test.ts that now pass.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

I guess the interface for StatelessActorProps was changed slightly, so if this is actually used in explicit form anywhere. Like a field like this, let actorProps: StatelessActorProps<LocalActorSystemRef> = ..., that line will fail. I find that it was basically a bug that the line would be accepted anyway because there is no such signature for ActorProps (one without State and Msg). However, with the logic that existing code that would work now would end up not compiling, it could be classified as a breaking change.

EDIT: Fixing of some edge case type logic has entailed changes to the types of dispatch and query as well as the original StatelessActorProps. It is hard to argue that this PR is anything other than a breaking change at this point.

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document. (I assume this has been renamed to CODE_OF_CONDUCT).
• I have added tests to cover my changes.
• All new and existing tests passed.