feat: Add graph memory access API, use correct node_sizes for node layout#44
Merged
mitchmindtree merged 2 commits intonannou-org:mainfrom Jan 19, 2026
Merged
Conversation
Expose `node_sizes()` method on `GraphTempMemory` and add `with_graph_memory()` function for efficient access to graph state. The function provides a closure-based API that avoids cloning data and automatically creates default memory if none exists. We now use the new API to correctly retrieve node sizes during layout in the demo. Previously we attempted to use `area_rect`, however it turns out this is only generated for `Area` widgets in egui, and so for the nodes it always returned `None`, resulting in the fallback node size for layout.
mitchmindtree
force-pushed
the
node-sizes
branch
from
d7b8f59 to
119da22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
node_sizes()method onGraphTempMemoryand addwith_graph_memory()function for efficient access to graph state. The function provides a closure-based API that avoids cloning data and automatically creates default memory if none exists.We now use the new API to correctly retrieve node sizes during layout in the demo. Previously we attempted to use
area_rect, however it turns out this is only generated forAreawidgets in egui, and so for the nodes it always returnedNone, resulting in the fallback node size for layout.