fix: Update framed methods to return InnerResponse<R>#45
Merged
mitchmindtree merged 2 commits intonannou-org:mainfrom Jan 19, 2026
Merged
fix: Update framed methods to return InnerResponse<R>#45mitchmindtree merged 2 commits intonannou-org:mainfrom
InnerResponse<R>#45mitchmindtree merged 2 commits intonannou-org:mainfrom
Conversation
JoshuaBatty
approved these changes
Jan 19, 2026
Changes `NodeCtx::framed()` and `framed_with()` to return `egui::InnerResponse<R>` instead of `egui::Response`, allowing content closures to return values that can be accessed by callers. Updates `NodeResponse` to be generic over the content's return type `R` and wraps `InnerResponse<R>` internally. Adds `inner()` and `inner_mut()` methods for accessing the returned value. This enables node implementations to return responses from UI widgets (e.g., button clicks, text edits) while still maintaining proper framing and interaction handling.
mitchmindtree
force-pushed
the
node-response
branch
from
1e26266 to
8729483
Compare
mitchmindtree
force-pushed
the
node-response
branch
from
8729483 to
e5b679d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NodeCtx::framed()andframed_with()to returnegui::InnerResponse<R>instead ofegui::Response, allowing content closures to return values that can be accessed by callers.Updates
NodeResponseto be generic over the content's return typeRand wrapsInnerResponse<R>internally. Addsinner()andinner_mut()methods for accessing the returned value.This enables node implementations to return responses from UI widgets (e.g., button clicks, text edits) while still maintaining proper framing and interaction handling.