update many models' output spec created_if conditions to be accurate …#2225
Draft
emlys wants to merge 6 commits intonatcap:mainfrom
Draft
update many models' output spec created_if conditions to be accurate …#2225emlys wants to merge 6 commits intonatcap:mainfrom
emlys wants to merge 6 commits intonatcap:mainfrom
Conversation
emlys
commented
Oct 31, 2025
| @@ -1675,9 +1667,7 @@ def _mask_below_start_value(array): | |||
| table_df = pandas.DataFrame(table_dict) | |||
|
|
|||
| # Write dataframe to csv, with columns in designated sequence | |||
| base_attribute_table_path = os.path.splitext(target_raster_path)[0] | |||
| attribute_table_path = base_attribute_table_path + '.csv' | |||
| table_df.to_csv(attribute_table_path, index=False, columns=column_names) | |||
Member
Author
There was a problem hiding this comment.
Modified this function to pass in the CSV path from the file registry rather than creating it from the raster name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on sample data
Also fixes #2070
Checklist