Fix Muon unit tests for reduce_scatter incompatibility assertion#3
Draft
Copilot wants to merge 3 commits intofix_unit_testsfrom
Draft
Fix Muon unit tests for reduce_scatter incompatibility assertion#3Copilot wants to merge 3 commits intofix_unit_testsfrom
Copilot wants to merge 3 commits intofix_unit_testsfrom
Conversation
Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unit test failures from pull request 7808
Fix Muon unit tests for reduce_scatter incompatibility assertion
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests for Muon optimizer fail after PR deepspeedai#7808 added assertion that Muon is incompatible with
reduce_scatter=True. Tests were using the defaultreduce_scatter=Truevalue.Changes
tests/unit/ops/muon/test_muon.py
reduce_scatter=Falsefor Muon optimizer tests, keepTruefor Adam testsTestMuonReduceScatterIncompatibilityto verify assertion triggers correctlyThe new test verifies that initializing Muon with
reduce_scatter=TrueraisesAssertionErrorwith message "incompatible with Muon optimizer".Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.