Rename pixelRatio functions to pixelScale#46
Open
joan-teriihoania wants to merge 1 commit intonativewind:mainfrom
Open
Rename pixelRatio functions to pixelScale#46joan-teriihoania wants to merge 1 commit intonativewind:mainfrom
joan-teriihoania wants to merge 1 commit intonativewind:mainfrom
Conversation
|
@joan-teriihoania is attempting to deploy a commit to the nativewind Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@joan-teriihoania is there a reason that this is a draft PR? |
Author
|
@danstepanov I wasn't sure if this issue should be resolved by a PR on the website, or on the package itself (see assumptions in description). Though, in retrospect, the draft isn't really warranted. I've marked this to ready for review. |
Member
|
Thanks for the PR @joan-teriihoania! I'll need to dig through this to ensure that everything is accurate but appreciate you being proactive about the solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to the
theme's customization documentation where thepixelRatioandpixelRatioSelectfunctions are not exported by the implementation (see #45 for more details), butpixelScaleandpixelScaleSelectare.This PR is based on the assumptions
pixelScaleandpixelRatiohave the same behaviour, side-effects, and outputs, then this could be a simple case of documentation-implementation reconciliation.Closes #45