Throw error instead of panic when reply subject is empty#1514
Open
liamkinne wants to merge 3 commits intonats-io:mainfrom
Open
Throw error instead of panic when reply subject is empty#1514liamkinne wants to merge 3 commits intonats-io:mainfrom
liamkinne wants to merge 3 commits intonats-io:mainfrom
Conversation
Contributor
Author
|
CI failure seems to be unrelated to this code change. |
Jarema
requested changes
Feb 16, 2026
Member
Jarema
left a comment
Jarema
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Please update the error.
Also - could you add a test?
you can find them in service_tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1511