Keep context and client fields for Publish and Request by reference#866
Open
caspervonb wants to merge 5 commits intonats-io:into-future-refactorfrom
Open
Keep context and client fields for Publish and Request by reference#866caspervonb wants to merge 5 commits intonats-io:into-future-refactorfrom
context and client fields for Publish and Request by reference#866caspervonb wants to merge 5 commits intonats-io:into-future-refactorfrom
Conversation
Co-Authored-By: Casper Beyer <caspervonb@pm.me>
Co-Authored-By: Casper Beyer <caspervonb@pm.me>
Co-Authored-By: Casper Beyer <caspervonb@pm.me>
Co-Authored-By: Casper Beyer <caspervonb@pm.me>
caspervonb
force-pushed
the
into-future-by-ref
branch
from
33d45c0 to
1a360fe
Compare
Collaborator
Author
|
Just broke #866 into atomic commits for rebase and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids clones to Client and Context when publishing messages and sending requests, instead binding them to a lifetime and holding onto the required state by reference.
Supersedes #866