fix(utility-billing): ensure meter readings are added to sales documents#100
Merged
muruthigitau merged 2 commits intodevelopfrom Jan 22, 2026
Merged
fix(utility-billing): ensure meter readings are added to sales documents#100muruthigitau merged 2 commits intodevelopfrom
muruthigitau merged 2 commits intodevelopfrom
Conversation
…scheduling Refactor the service request feature to improve separation of concerns, data consistency, and automation. Key changes: - Add a daily scheduler job to centrally run auto-repeat processing - Update site survey flow to return Issue defaults from the server, letting the client create the Issue for better navigation and permissions - Replace client-side status checks with a server-side update_request_status method that derives status from related Issues and persists changes only when needed - Add utility_property field to the doctype and wire property selection into sales document creation and item preparation - Clean up frontend logic: refactor dialogs/modals, improve item table preparation and row editing UX, remove redundant saves and comments - Fix backend edge cases (e.g. clear end_date when length is zero) Overall, this improves reliability, clarity, and maintainability of the service request UI and auto-repeat processing.
Fixes an issue where meter readings were not being populated into Sales Orders and Sales Invoices. Key changes: - Centralized meter-reading synchronization into a reusable routine. - Added validation hooks on Sales Order and Sales Invoice to trigger syncing. - Auto-populated meter-reading rows from linked Meter Reading records. - Updated field mappings to correctly propagate qty, stock UOM, and meter_reading values. - Refactored client-side queries to correctly filter and auto-select property and meter-number options. - Removed redundant fields from Sales Invoice Meter Reading and Sales Order Meter Reading doctypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where meter readings were not being populated into Sales Orders and Sales Invoices.
Key changes:
and meter_reading values.
property and meter-number options.