Fsdk: added UnwrapEither function

[webwarrior-ws]

Added UnwrapEither function.

[knocte]

@webwarrior-ws FSharpUtil.ReRaise is for async jobs, not this; read the comment that is placed in ReRaise function please

[webwarrior-ws]

@webwarrior-ws FSharpUtil.ReRaise is for async jobs, not this; read the comment that is placed in ReRaise function please

That is what NOnion's UnwrapResult was using.

[knocte]

@aarani before we use this in NOnion let's fix this ^

[knocte]

@aarani ping

[aarani]

I'm confused you want to make a commit to fix something you want to replace afterward?

[aarani]

@webwarrior-ws @knocte should correct me but I guess raise ex is enough here

[knocte]

I realised now what's wrong here. Look, you're mixing error-handling models. There's one model: exceptions, and then there's another model: Result types. With this thing you're mixing both models in one: a Failure monad that has an exception type??? This is super weird. Resullt types should contain error types which are normally DUs, not Exceptions.

[webwarrior-ws]

I agree that it's a questionable design choice. But it's used all over NOnion.
So what do we do with OperationResult and UnwrapResult?

[knocte]

But it's used all over NOnion.

Let's work on fixing this first then. Taras can do it to offload you from it.

[knocte]

Let's work on fixing this first then. Taras can do it to offload you from it.

Oops I thought I was replying to Afshin. Anyway, my comment still stands.