feat(spice): epoch transition with uncertified chunks last_proposal#14980
Draft
darioush wants to merge 5 commits intonear:masterfrom
Draft
feat(spice): epoch transition with uncertified chunks last_proposal#14980darioush wants to merge 5 commits intonear:masterfrom
darioush wants to merge 5 commits intonear:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14980 +/- ##
===========================================
+ Coverage 1.30% 68.80% +67.50%
===========================================
Files 725 919 +194
Lines 140594 201207 +60613
Branches 140594 201207 +60613
===========================================
+ Hits 1835 138447 +136612
+ Misses 138706 56790 -81916
- Partials 53 5970 +5917
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpiceCoreStatement::ChunkExecutionResultentries instead of chunk headers.last_proposalsto prevent incorrect stake return. Without this, a validator who re-stakes late in an epoch could have their locked stake incorrectly returned.