Perofrment and consistent type scan#282
Open
shlomiassaf wants to merge 1 commit intonenoNaninu:mainfrom
Open
Conversation
…location for all source types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source types are sceanned multiple times along the initialization process.
The types should be identical and should be stored in a single location so the type scan process is done once and it is consistent across the process.
This removes all duplicate scans and use a single location for all source types.
Note that for backward compatibility i've left the scan in 2 locations
TranspilationOptions- There is a constructor that apply additional scanTypeScriptCodeGeneratorhas a constructor that does it for backwards compatibilityIf you accept this PR you can in next version remove the above.