fix(compiler): fix critical security and optimizer bugs #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecurityAnalyzer fixes: - Fix typos: Analzyer -> Analyzer in class names (3 occurrences) - Fix wrong bitwise operator | -> & in UpdateAnalyzer (CallFlags check) - Fix byte array comparison == -> SequenceEqual in UpdateAnalyzer - Add missing GetSourceLocation helper in WriteInTryAnalyzer Peephole optimizer fixes: - Fix operator precedence bugs in pattern matching (3 occurrences) - (A && B || C) -> ((A && B) || C) Instruction disassembler fix: - Fix incorrect span offset for PUSHDATA2/PUSHDATA4 string extraction - PUSHDATA2: AsSpan(1) -> AsSpan(2) - PUSHDATA4: AsSpan(1) -> AsSpan(4) All 944 compiler unit tests pass.
…g fixes Add unit tests demonstrating fixes for: 1. UpdateAnalyzer security fixes: - Test_CallFlags_BitwiseOperator_Fix: Verifies (flags | WriteStates) -> (flags & WriteStates) - Test_ByteArray_Comparison_Fix: Verifies SequenceEqual vs reference equality 2. Peephole optimizer fixes: - Tests for operator precedence fixes in pattern matching - Tests verify optimization doesn't crash on various patterns 3. Instruction disassembler fixes: - Tests for PUSHDATA2/PUSHDATA4 span offset fixes - Tests verify correct data extraction from operands Also update existing WriteInTry tests to use corrected class name (WriteInTryAnalyzer). All 961 compiler unit tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes critical bugs found during code review:
SecurityAnalyzer Fixes
Class Name Typos
Critical Logic Bugs in UpdateAnalyzer
Line 45: Fixed wrong bitwise operator -> for CallFlags check
Line 53: Fixed byte array comparison ->
WriteInTryAnalyzer Compilation Fix
Peephole Optimizer Fixes
Operator Precedence Bugs (3 occurrences)
Fixed incorrect pattern matching due to having higher precedence than :
Instruction Disassembler Fix
Testing
All 944 compiler unit tests pass after these changes.