Open
Conversation
erikzhang
reviewed
Jan 16, 2026
| } | ||
| wallet.Save(); | ||
|
|
||
| if (CurrentWallet is not null) SignerManager.UnregisterSigner(CurrentWallet.Name); |
Member
There was a problem hiding this comment.
Does SignerManager's role overlap with IWalletProvider's?
Member
There was a problem hiding this comment.
IWalletProvider covers access to the currently active wallet. SignerManager is being used as an ISigner registry to centralize signing (and potentially support other signers beyond wallets). That said I agree an improvement would be to have SignerManager automatically stay in sync by subscribing to IWalletProvider.WalletChanged (e.g. as a follow-up) so we don’t need to manually Register/Unregister in every wallet changing command
Wi1l-B0t
approved these changes
Jan 16, 2026
cschuchardt88
approved these changes
Jan 17, 2026
Contributor
Member
|
Need #989 |
Contributor
|
UT failed. |
Member
Author
master build failed, is not related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #974