Conversation
|
|
||
| console.log(`Functional tests results from ${reportPath}:`); | ||
| console.log(` - Passed = ${passedTests}`); | ||
| console.log(` - Failed = ${failedTests}`); |
There was a problem hiding this comment.
| console.log(`Functional tests results from ${reportPath}:`); | ||
| console.log(` - Passed = ${passedTests}`); | ||
| console.log(` - Failed = ${failedTests}`); | ||
| console.log(` - Skipped = ${skippedTests}`); |
There was a problem hiding this comment.
| console.log(` - Skipped = ${skippedTests}`); | ||
|
|
||
| if (failedTests > 0 || skippedTests > 0) { | ||
| console.log('[ERROR] Not all tests have passed.'); |
There was a problem hiding this comment.
| } | ||
|
|
||
| if (expectedPassedTests >= 0 && parseInt(expectedPassedTests, 10) !== passedTests) { | ||
| console.log(`[ERROR] Expected number of passed tests (${expectedPassedTests}) does not match actual number of passed tests (${passedTests}).`); |
There was a problem hiding this comment.
| const failedTests = parseInt(require(reportPath).state.failed, 10); | ||
| const skippedTests = parseInt(require(reportPath).state.skipped, 10); | ||
|
|
||
| console.log(`Functional tests results from ${reportPath}:`); |
There was a problem hiding this comment.
| const skippedTests = parseInt(require(reportPath).state.skipped, 10); | ||
|
|
||
| console.log(`Functional tests results from ${reportPath}:`); | ||
| console.log(` - Passed = ${passedTests}`); |
There was a problem hiding this comment.
racodond
force-pushed
the
fix109
branch
3 times, most recently
from
315a1af to
b134abc
Compare
|
I’ll need to check that together, I have several questions to understand everything. |
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. 1 extra issueNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
What's the difference between Chrome and Firefox files?
If there's none, couldn't we have only one?
| echo "Project dependencies installed." | ||
|
|
||
| echo "Running tests in Chrome Docker container..." | ||
| npx ntaf run --realm=docker-chrome --tagExpression='@mytest' |
| echo "Project dependencies installed." | ||
|
|
||
| echo "Running tests in Chrome Docker container..." | ||
| npx ntaf run --realm=docker-chrome |
There was a problem hiding this comment.
As the only difference seems to be the realm that we pass to npx ntaf run (which make sense), could we simplify it by passing only the npm parameters to npx ntaf run-in-docker and hide the complexity behind? (in theory we should not expose end-user to underlying complexity and I fill like we're doing it when we ask him to create a shell script under docker/ directory and pass it into parameters.
Ideally we should use the run-in-docker same way we use npx ntaf run, meaning npy ntaf run-in-docker --realm=chrome.
I think it would also remove some code here.
We can discuss further if needed, I might not be clear :-)
2 participants
No description provided.