fix(type): config service get and getOrThrow methods return type#2072
Open
PongDev wants to merge 1 commit intonestjs:masterfrom
Open
fix(type): config service get and getOrThrow methods return type#2072PongDev wants to merge 1 commit intonestjs:masterfrom
PongDev wants to merge 1 commit intonestjs:masterfrom
Conversation
When a ConfigService type is provided, the return type should match the given type; otherwise, a compile error should occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ConfigService type is provided, the return type should match the given type; otherwise, a compile error should occur.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
When the type of receiver variable and the type provided by ConfigService don't match, no error occurs.
What is the new behavior?
When a ConfigService type is provided, a typescript compile error will occur if return type and given type doesn't match.
Does this PR introduce a breaking change?
If a variable type has previously provided but doesn't match the return type provided in ConfigService, typescript will produce a compile error and
// @ts-ignoreis required to ignore error.Other information