feat: Add exclude as a complement to exclude.#1289
Open
evantrimboli wants to merge 1 commit intonestjs:masterfrom
Open
feat: Add exclude as a complement to exclude.#1289evantrimboli wants to merge 1 commit intonestjs:masterfrom
evantrimboli wants to merge 1 commit intonestjs:masterfrom
Conversation
|
@evantrimboli I would grateful if you would resolve conflicts to push it further. I also need this feature 🙂 |
Member
|
The code here looks solid. If we can get the conflicts resolved I could see this being useful. |
Author
|
Upon reflection I think this PR doesn't make sense as-is. I think it would be better to alter the type of include to: type IncludeFn = (module: Function) => boolean;
include?: IncludeFn | Function[]; |
Member
Oh, even better with less complexity. I'm game for that |
|
Was this included on another PR or it was abandoned? |
saccoe
approved these changes
Nov 28, 2023
benjGam
approved these changes
May 29, 2024
|
Is it ready to merge after resolving the conflicts? |
Member
Yeah I agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#1288
Issue Number: 1288
What is the new behavior?
excludeworks as a complement toinclude.Does this PR introduce a breaking change?
Other information