The single quote breaks the strings in Android. We should escape them#88
Open
ctarabusi wants to merge 2 commits intonetbe:masterfrom
Open
The single quote breaks the strings in Android. We should escape them#88ctarabusi wants to merge 2 commits intonetbe:masterfrom
ctarabusi wants to merge 2 commits intonetbe:masterfrom
Conversation
lib/babelish/csv2android.rb
Outdated
| def process_value(row_value, default_value) | ||
| value = super(row_value, default_value) | ||
| # if the value begins and ends with a quote we must leave them unescapted | ||
| value.gsub!(/'/, {"'" => "\\'"}) # escape single quote only for Android |
Collaborator
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
Space inside { missing.
Space inside } missing.
|
Changes Unknown when pulling 95ba087 on ctarabusi:fix-android-single-quote-escaping into * on netbe:master*. |
|
Changes Unknown when pulling bc97884 on ctarabusi:fix-android-single-quote-escaping into * on netbe:master*. |
Owner
|
@ctarabusi sure just check the unit tests on travis, they are not passing right now. |
Owner
|
Hey @ctarabusi, please rebase with master and fix tests: |
Owner
|
@ctarabusi any interest in finishing/commenting on the state of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Francois,
I hope you are well, would you care to review this PR and eventually merge it?