feat(image): add image upload support#716
Conversation
|
@NeverBehave please don't request reviews from individuals unless someone has previously volunteered. We utilize a rotation for assignment of reviewers. |
|
@jeremystretch The request is sent automatically(and won't be able to deselect) by Github since this repo has defined CODEOWNERS, which was added 7 month ago by @arthanson |
|
My mistake, thanks for pointing that out. Not sure why that was added as it's not needed. I've opened #717 to remove it. |
arthanson
left a comment
There was a problem hiding this comment.
@NeverBehave this looks very good, just a couple questions below.
|
@arthanson thanks for the review. Both cases updated with corresponded tests covered. Let me know if there is any other concerns. |
|
@NeverBehave some of the tests are failing, can you please check |
|
@NeverBehave, in the future, please comment on the original issue asking that it be assigned to you. We do not accept PRs for unassigned issues. Since this has already received a review, please comment on #520 now so that I can assign to you. |
|
@jnovinger I leave a comment on the original issue. Let me know anything else needed. It would be great if this process("ask for assignment") documented in https://github.com/netbox-community/pynetbox/blob/c70d57b455ece7fb5fa6e291a1c6901a60b88054/docs/development/index.md?plain=1 Some other quick housekeeping thoughts:
|
arthanson
left a comment
There was a problem hiding this comment.
Thanks @NeverBehave !
|
Quick question — what’s the usual release cadence for this project? |
Fixes: #520
This PR adds automatic file upload support for endpoints that accept files (e.g., image attachments, device type images).
Changes:
create()/save()data and switch from JSON tomultipart/form-dataencoding_is_file_like()and_extract_files()in query.py