feat: propogate debug flag to worker backend.#275
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdc5eee555
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if d.debug { | ||
| dOptions = append(dOptions, "--debug") | ||
| } |
There was a problem hiding this comment.
Gate debug flag on worker capability check
When --debug is enabled, Start now always appends --debug to the worker command, but this bypasses the newly added compatibility check and can break startup with older orb-worker binaries that do not support that flag. The commit introduces checkWorkerSupportsDebug() specifically to avoid this scenario, so Start should only append --debug when that check succeeds.
Useful? React with 👍 / 👎.
|
Go test coverage
Total coverage: 58.8% |
Description
This PR introduces support for a debug flag that propagates from the CLI to the agent and down to the worker backend, enabling the orb-worker process to be started with the --debug flag if supported. The changes include:
Testing
Unit Tests
Dev Test
Tested locally against with local aci integration against live cisco-aci lab environment.