reconcile main branch and add failure policy#39
Merged
dariuszSki merged 7 commits intorefactor-for-routerfrom Feb 22, 2025
Merged
reconcile main branch and add failure policy#39dariuszSki merged 7 commits intorefactor-for-routerfrom
dariuszSki merged 7 commits intorefactor-for-routerfrom
Conversation
qrkourier
changed the title
qrkourier
commented
Feb 20, 2025
| - key: kubernetes.io/metadata.name | ||
| operator: NotIn | ||
| values: | ||
| - kube-system |
Member
Author
There was a problem hiding this comment.
exclude kube-system namespace from selectors
ziti-agent/cmd/webhook/pods.go
Outdated
| zh.Config.ResolverIp = service.Spec.ClusterIP | ||
| } else { | ||
| klog.Info("Looked up DNS SVC ClusterIP and is not found") | ||
| zh.Config.ResolverIp = defaultClusterDnsServiceIP |
Member
Author
There was a problem hiding this comment.
assign default if lookup fails
| "-i", | ||
| fmt.Sprintf("%v.json", identityName), | ||
| }, | ||
| Args: []string{"tproxy"}, |
Member
Author
There was a problem hiding this comment.
no need to specify identity name since it's always managed and invisible, so "ziti_id" default is fine for now.
qrkourier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ZITI_AGENT_WEBHOOK_FAILURE_POLICYto override default fail policy if webhook ops fail for some reason