Open
Conversation
- timo comments
- add components and services for user impersonation - extend UserResource, User and UserTransformer classes - add demo component to example app
- fix example app component
- override permission with impersonated user
- improve impersonation stream
- rename and move component
- implement impersonation by config (alternative to impersonation directly by user id)
- add buttons for impersonation into drawer components - add localization (german todo)
- improve visual (bigger menu for impersonation) - change impersonation case view headers
- clean up
- fix test
- fix for lint
- fix test
- code smell - add tests for impersonation.service
- fix test
- add de locale for impersonation
- add de locale for impersonation
- update according to PR comments
- improvements based on PR comments
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json
- improvements based on machacjozef PR comments
- fix test after merge
- changes based on PR comments
[NAE-1678] User impersonation
[NAE-1797] I18N field at asynchronous rendering
[NAE-1790] Validation message on the date field is not displaying correctly
[NAE-1759] Update documentation of public views, PDF generator and user list
# Conflicts: # package.json # projects/netgrif-components-core/package.json # projects/netgrif-components/package.json
- implemented required changes for frontend too
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Implemented required changes for authority refactor.
Implements NAE-1617
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Checklist: