[NAE-2290] Couldn't find referenced task in a taskref incoming from event outcome

[Kovy95]

Description

• change forEach to for

Fixes NAE-2290

Dependencies

none

Third party dependencies

• No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

manually

Test Configuration

Name	Tested on
OS	LinuxMint22
Runtime	Node.js 20
Dependency Manager	NPM 10
Framework version	Angular 17
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @...
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• Performance Improvements
  • Task reference lookup now exits immediately when a matching reference is found, shortening lookup time and improving responsiveness for task-related views and operations. This reduces unnecessary processing without changing visible behavior when no match exists.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaced the inner iteration over referencedTaskIds in findTaskRefId with a for...of loop to allow an early return when a matching TaskRefField is found. No public signatures changed; behavior when no match is found remains the same.

Changes

Cohort / File(s)	Summary
TaskContentService loop change projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts	Replaced Array.forEach iteration over referencedTaskIds with a for...of loop in findTaskRefId, enabling immediate return once a matching TaskRefField is found (short-circuits search).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Check that early exit is intended and doesn't skip necessary side effects (none expected).
• Verify behavior when no match is found remains unchanged.

Possibly related PRs

• [NAE-2268] Fix resolving of referenced taskId on frontend #312: Also modifies the same findTaskRefId function (flattens referencedTaskIds) — related to lookup logic.
• [NAE-2231] Unable to change behavior of taskRef on finish event witho… #307: Changes TaskContentService methods (updateStateData/updateField) affecting task-ref reload behavior in the same service.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main issue being fixed (couldn't find referenced task in taskref from event outcome) and maps to the code change (replacing forEach with for-of loop for early return). It is specific and directly related to the primary purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1f375 and 3c31c12.

📒 Files selected for processing (1)

• projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts (1)

projects/netgrif-components-core/src/lib/task-content/task-content/abstract-task-content.component.ts (1)

• taskId (160-162)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Matrix Test (14)
• GitHub Check: Matrix Test (16)
• GitHub Check: Matrix Test (18)
• GitHub Check: Test with SonarCloud

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42949df and 3b1f375.

📒 Files selected for processing (1)

• projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts (1)

projects/netgrif-components-core/src/lib/task-content/task-content/abstract-task-content.component.ts (1)

• taskId (160-162)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud