[release-1.11] NETOBSERV-2596: Make console plugin controller use health metadata for config, set some default rules as recording

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2388

/assign jotak

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2596

Details

In response to this:

This is an automated cherry-pick of #2388

/assign jotak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jotak]

/lgtm

[codecov]

Codecov Report

❌ Patch coverage is 87.82609% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.17%. Comparing base (4725fe7) to head (ea75f9e).
⚠️ Report is 1 commits behind head on release-1.11.

Files with missing lines	Patch %	Lines
internal/pkg/metrics/alerts/dns_nxdomain.go	50.00%	16 Missing ⚠️
internal/pkg/metrics/alerts/builder.go	89.32%	6 Missing and 5 partials ⚠️
internal/pkg/metrics/alerts/netpol_denied.go	56.00%	11 Missing ⚠️
internal/pkg/metrics/alerts/context.go	91.11%	6 Missing and 2 partials ⚠️
internal/pkg/metrics/alerts/device_drops.go	82.22%	8 Missing ⚠️
internal/pkg/metrics/alerts/ingress_errors.go	80.00%	6 Missing and 1 partial ⚠️
...l/pkg/metrics/alerts/ingress_http_latency_trend.go	82.50%	6 Missing and 1 partial ⚠️
internal/pkg/metrics/alerts/promql.go	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.11    #2413      +/-   ##
================================================
+ Coverage         71.84%   72.17%   +0.32%     
================================================
  Files                93      104      +11     
  Lines             10567    10619      +52     
================================================
+ Hits               7592     7664      +72     
+ Misses             2493     2480      -13     
+ Partials            482      475       -7     

Flag	Coverage Δ
unittests	72.17% <87.82%> (+0.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/controller/consoleplugin/config/config.go	75.00% <ø> (ø)
.../controller/consoleplugin/consoleplugin_objects.go	86.72% <100.00%> (-0.17%)	⬇️
internal/controller/flp/flp_monolith_reconciler.go	68.27% <100.00%> (ø)
internal/controller/flp/flp_transfo_reconciler.go	63.49% <100.00%> (ø)
internal/pkg/metrics/alerts/dns_errors.go	100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/external_trend.go	100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/ipsec_errors.go	100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/kernel_drops.go	100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/latency_trend.go	100.00% <100.00%> (ø)
internal/pkg/metrics/alerts/operational_alerts.go	100.00% <100.00%> (ø)
... and 8 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.