Update recommendations:

[jotak]

• Refresh from the downstream doc, some items were outdated (e.g. test beds still had the old 65 nodes)
• Extract test bed data out of the table, to clarify these are not recommendations
• Add info about where to find the mentioned settings
• Refresh cacheMaxSize with updated information from this release
• Rename Kafka consumer replicas => Consumer replicas, according to this release updates
• Add recommended deployment model more explicitly
• Recommend Service rather than Direct in 10-nodes clusters

cc @memodi @gwynnemonahan

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

/cherry-pick release-1.11

[openshift-cherrypick-robot]

@jotak: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.15%. Comparing base (e93240b) to head (576483d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   72.18%   72.15%   -0.03%     
==========================================
  Files         104      104              
  Lines       10619    10619              
==========================================
- Hits         7665     7662       -3     
- Misses       2478     2481       +3     
  Partials      476      476              

Flag	Coverage Δ
unittests	72.15% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[memodi]

we're dropping LokiStack size recommendation? IMO we should keep it 1x.extra-small (10 nodes), 1x.small (25 nodes) and 1x.medium (250 nodes)

[jotak]

I moved that out of the recommendations, to the test beds. It's still visible above. idk, I think we have a different place where we document the recommended loki stack size with different criteria, I don't want to mix up things here, wdyt?

See also: https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html/network_observability/installing-network-observability-operators#loki-deployment-sizing_network_observability

[memodi]

I see, okay, that sounds good to me then.

[stleerh]

Prior to the Resource considerations section, it says:

As it operates cluster-wide on every node, only a single `FlowCollector` is allowed, and it has to be named `cluster`.

A couple of settings deserve special attention:

The first sentence should be changes since it's not necessarily every node anymore.

A new setting that should be added is consumer replicas.

[jotak]

The first sentence should be changes since it's not necessarily every node anymore.

You refer to the node toleration settings, right? Hmm... how would you reformulate? If we want to keep the justification why it's a singleton resource, we may run into a convoluted explanation , because it's true that now, it could make sense to have several FlowCollectors.
I would say either we keep it as is as a "globally true-ish assertion, simplified" :-)
Or we just remove the justification.

A new setting that should be added is consumer replicas.

It's not really new when we used Kafka before; but yes, can be added

[jotak]

@stleerh done; I've removed the mention of "every nodes"

[mffiedler]

LGTM

[openshift-cherrypick-robot]

@jotak: new pull request created: #2446

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stleerh]

/lgtm