Skip to content

Fix doc issues with slices#2444

Merged
jotak merged 2 commits intonetobserv:mainfrom
jotak:fix-slices-doc
Feb 11, 2026
Merged

Fix doc issues with slices#2444
jotak merged 2 commits intonetobserv:mainfrom
jotak:fix-slices-doc

Conversation

@jotak
Copy link
Member

@jotak jotak commented Feb 11, 2026

  • Mention "EXT:" prefix in slices
  • Mention "EXT:" prefix in label names
  • Fix bad copy-paste of FlowMetric within Slices doc

Regenerate docs

cc @gwynnemonahan

- Mention "EXT:" prefix in slices
- Mention "EXT:" prefix in label names
- Fix bad copy-paste of FlowMetric within Slices doc

Regenerate docs
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member Author

jotak commented Feb 11, 2026

/cherry-pick release-1.11

@openshift-cherrypick-robot

@jotak: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gwynnemonahan
Copy link
Collaborator

Thank you!

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (e93240b) to head (d5a6b4c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2444      +/-   ##
==========================================
+ Coverage   72.18%   72.20%   +0.01%     
==========================================
  Files         104      104              
  Lines       10619    10619              
==========================================
+ Hits         7665     7667       +2     
  Misses       2478     2478              
+ Partials      476      474       -2     
Flag Coverage Δ
unittests 72.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
...ollectorslice/v1alpha1/flowcollectorslice_types.go 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwynnemonahan
Copy link
Collaborator

LGTM

@jotak jotak merged commit 56f1e43 into netobserv:main Feb 11, 2026
14 of 15 checks passed
@jotak jotak deleted the fix-slices-doc branch February 11, 2026 15:29
@openshift-cherrypick-robot

@jotak: new pull request created: #2448

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants