Skip to content

Set GOMEMLIMIT on FLP#2447

Merged
jotak merged 3 commits intonetobserv:mainfrom
jotak:flp-mem-limit
Feb 12, 2026
Merged

Set GOMEMLIMIT on FLP#2447
jotak merged 3 commits intonetobserv:mainfrom
jotak:flp-mem-limit

Conversation

@jotak
Copy link
Member

@jotak jotak commented Feb 11, 2026

(Same as done on the agent)

The agent has GOMEMLIMIT set relative to the kube limits, and FLP did not have the same thing implemented. This brings the same behaviour to FLP.

(Same as done on the agent)
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 11, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:f907c41
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-f907c41
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-f907c41

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:f907c41 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-f907c41

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-f907c41
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 11, 2026
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 11, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:bfe85f5
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-bfe85f5
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-bfe85f5

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:bfe85f5 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-bfe85f5

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-bfe85f5
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 11, 2026
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 11, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:e69e9cd
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e69e9cd
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e69e9cd

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e69e9cd make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-e69e9cd

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-e69e9cd
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.26%. Comparing base (1faaa78) to head (973aa74).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2447      +/-   ##
==========================================
+ Coverage   72.20%   72.26%   +0.06%     
==========================================
  Files         104      104              
  Lines       10619    10624       +5     
==========================================
+ Hits         7667     7677      +10     
+ Misses       2478     2474       -4     
+ Partials      474      473       -1     
Flag Coverage Δ
unittests 72.26% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/ebpf/agent_controller.go 60.62% <100.00%> (-0.24%) ⬇️
internal/controller/flp/flp_common_objects.go 92.28% <100.00%> (+0.02%) ⬆️
internal/pkg/helper/comparators.go 68.46% <100.00%> (+0.28%) ⬆️
internal/pkg/helper/env.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak
Copy link
Member Author

jotak commented Feb 12, 2026

merging, needed for the release
/cherry-pick release-1.11

@openshift-cherrypick-robot

@jotak: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

merging, needed for the release
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak jotak merged commit b4c06c9 into netobserv:main Feb 12, 2026
12 of 13 checks passed
@openshift-cherrypick-robot

@jotak: new pull request created: #2450

Details

In response to this:

merging, needed for the release
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants