NETOBSERV-2375: make consistent status handling

[jotak]

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

• They are initialized unknown
• When controller found unused, status set to unused
• At any point, if an error occurs, it's set with that error
• Deployment/DaemonSet check progress set status either as InProgress, or Ready
• New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

• New status: WaitingEBPFAgents
• New status: WaitingWebConsole
• New status: WaitingDemoLoki
• New status: WaitingLokiStack
• Renamed status: WaitingFlowCollectorLegacy => WaitingFlowCollectorController
• Removed: LokiIssue and LokiWarning

Dependencies

• NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

• They are initialized unknown
• When controller found unused, status set to unused
• At any point, if an error occurs, it's set with that error
• Deployment/DaemonSet check progress set status either as InProgress, or Ready
• New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

• New status: EBPFAgents
• New status: WebConsole
• New status: DemoLoki
• New status: LokiStack
• Renamed status: FlowCollectorLegacy => FlowCollectorController
• Removed: LokiIssue and LokiWarning

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

• They are initialized unknown
• When controller found unused, status set to unused
• At any point, if an error occurs, it's set with that error
• Deployment/DaemonSet check progress set status either as InProgress, or Ready
• New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

• New status: EBPFAgents
• New status: WebConsole
• New status: DemoLoki
• New status: LokiStack
• Renamed status: FlowCollectorLegacy => FlowCollectorController
• Removed: LokiIssue and LokiWarning

Dependencies

• NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-2375 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Address some old "TODOs" in status management. All statuses now follow this pattern:

• They are initialized unknown
• When controller found unused, status set to unused
• At any point, if an error occurs, it's set with that error
• Deployment/DaemonSet check progress set status either as InProgress, or Ready
• New Degraded condition can be optionally set; a degraded status does not prevent it from being "ready".

Make the LokiStack status fit in this model (it was previously using an entirely different pattern)

Also, previously, in 2 different places LokiStack was fetched to get its status (for propagating status into FlowCollector status and into console plugin config) Now consolidated into a single entry point to get the loki status.

Status changes:

• New status: WaitingEBPFAgents
• New status: WaitingWebConsole
• New status: WaitingDemoLoki
• New status: WaitingLokiStack
• Renamed status: WaitingFlowCollectorLegacy => WaitingFlowCollectorController
• Removed: LokiIssue and LokiWarning

Dependencies

• NETOBSERV-2375: adapt statuses to operator changes; sort conditions netobserv-web-console#1319

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.