NETOBSERV-2596: Unify Health sources#1232
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 49.35% 50.54% +1.18%
==========================================
Files 221 222 +1
Lines 12162 11961 -201
Branches 1590 1509 -81
==========================================
+ Hits 6003 6046 +43
+ Misses 5595 5340 -255
- Partials 564 575 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jotak
force-pushed
the
unify-data-model
branch
from
2b6adfe to
8658425
Compare
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=bcf6834 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
jotak
force-pushed
the
unify-data-model
branch
from
a140298 to
b54d393
Compare
|
I've rebased based on #1238 |
|
Comment posted by @memodi on #1238 (for the record) : @jpinsonneau I am seeing an issue where Workload alerts are not showing in its tab, even though they're firing: 
they're getting combined into NS tab looks like: 
|
- Recording rules and Alerts are merged as "HealthItem" early in the process (post-fetching) - Get recording health annotation info from the operator, more similar to what we have with alerts Topology: fetch all health (not only alerts) Reuse existing functions Rely on the existing per-resource grouping to match with topology elements Health page, tab icon was inconsistent with severity
jotak
force-pushed
the
unify-data-model
branch
from
b54d393 to
8a34e03
Compare
- Workload labels are taken from metadata - Include Kind labels as well, so we don't need to try to guess it - Add test on grouping - Remove some old TODO in code - Webpack: do transpileOnly just for container builds, not `make build`
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=a5bf52a make set-plugin-image |
|
/retest |
- Move health card css to its own file, imported from the component - rename pageSection id to a unique one across our pages
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2b00bf4 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=ebc960c make set-plugin-image |
|
@jotak: This pull request references NETOBSERV-2596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
| RUN TRANSPILE_ONLY=true FLAVOR=$FLAVOR npm run build$BUILDSCRIPT | ||
| RUN TRANSPILE_ONLY=true npm run build:static |
There was a problem hiding this comment.
image building and plugin-cypress test are consistently failing on this PR
Do we need these changes in Dockerfile.cypress as well?
There was a problem hiding this comment.
I'll do that; that shouldn't cause a failure, however it makes the jobs faster, if it's a matter of jobs timing out?
leandroberetta
left a comment
leandroberetta
left a comment
There was a problem hiding this comment.
Code looks good and cleaner. I think the changes to the other Dockerfiles needs to be added to the Cypress one.
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f4be918 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=21d8c1a make set-plugin-image |
|
/label qe-approved |
|
@jotak: This pull request references NETOBSERV-2596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-1.11 |
|
@jotak: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jotak: new pull request created: #1258 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Description
Dependencies
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.