NETOBSERV-1965: Add UDNs merger logic to merge udns accross nodes for the same flow

[msherif1234]

Description

need to merge UDNs across nodes for the same flow like we do today for interfaces and directions

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:be118dc

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=be118dc make set-plugin-image

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:791df49

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=791df49 make set-plugin-image

[jpinsonneau]

Code looks good, thanks @msherif1234

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:6dcb777

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6dcb777 make set-plugin-image

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:d926aab

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d926aab make set-plugin-image

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:471fe5d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=471fe5d make set-plugin-image

[jpinsonneau]

Code looks good 👌

@jotak should we proceed with Udns?: string[]; ?
What's the plan for the topology ?
@jpinsonneau this PR netobserv/network-observability-operator#1050 is removing UDN field

[msherif1234]

/test plugin-cypress

[msherif1234]

/hold
waiting for agreement on merge udns across nodes or leave them w/o merge ?

[jotak]

@msherif1234 I'm testing this PR with this additional change:

in ids.ts, function get5Tuple changed to:

export const get7Tuple = (r: Record): string => {
  return `${r.fields.SrcAddr}:${r.fields.SrcPort || 'x'}:${r.fields.SrcK8S_NetworkName || 'x'}→${r.fields.DstAddr}:${r.fields.DstPort || 'x'}:${r.fields.DstK8S_NetworkName || 'x'}@${r.fields.Proto}`;
};

Do you want me to push on your branch?
sure

[msherif1234]

/unhold

[openshift-ci-robot]

@msherif1234: This pull request references NETOBSERV-1965 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

need to merge UDNs across nodes for the same flow like we do today for interfaces and directions

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jotak]

Do you want me to push on your branch?

sure

done

[jpinsonneau]

LGTM !

Just need make fmt 👼

[openshift-ci]

New changes are detected. LGTM label has been removed.

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:d42fe47

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d42fe47 make set-plugin-image

[openshift-ci]

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/plugin-cypress	6c6f091	link	true	/test plugin-cypress
ci/prow/qe-e2e-console-tests	6c6f091	link	false	/test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment