Skip to content

update webhook check for 4.18 features and pktDrop#1044

Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
msherif1234:drop_chk
Jan 22, 2025
Merged

update webhook check for 4.18 features and pktDrop#1044
openshift-merge-bot[bot] merged 1 commit intonetobserv:mainfrom
msherif1234:drop_chk

Conversation

@msherif1234
Copy link
Contributor

Description

update validationn check for 4.18 features NetworkEvent, UDNMapping and EbpfManager
and add OCP version check for pktDrop feature

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234 msherif1234 requested a review from jotak January 22, 2025 12:54
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.56%. Comparing base (eb78f36) to head (e7f24df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lector/v1beta2/flowcollector_validation_webhook.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   62.52%   62.56%   +0.03%     
==========================================
  Files          77       77              
  Lines       11560    11563       +3     
==========================================
+ Hits         7228     7234       +6     
+ Misses       3876     3873       -3     
  Partials      456      456              
Flag Coverage Δ
unittests 62.56% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lector/v1beta2/flowcollector_validation_webhook.go 70.25% <75.00%> (+2.02%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 933970a into netobserv:main Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants