Skip to content

Automatic UDN enrichment#1045

Merged
jotak merged 1 commit intonetobserv:mainfrom
jotak:auto-udn
Jan 23, 2025
Merged

Automatic UDN enrichment#1045
jotak merged 1 commit intonetobserv:mainfrom
jotak:auto-udn

Conversation

@jotak
Copy link
Member

@jotak jotak commented Jan 22, 2025

Automatically configure enrichment with secondary network config when UDN is configured

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.35%. Comparing base (eb78f36) to head (e7c4d3a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
controllers/flp/flp_pipeline_builder.go 7.69% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   62.52%   62.35%   -0.18%     
==========================================
  Files          77       77              
  Lines       11560    11576      +16     
==========================================
- Hits         7228     7218      -10     
- Misses       3876     3900      +24     
- Partials      456      458       +2     
Flag Coverage Δ
unittests 62.35% <7.69%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controllers/flp/flp_pipeline_builder.go 71.12% <7.69%> (-4.28%) ⬇️

... and 3 files with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2025
@jotak jotak merged commit 564084e into netobserv:main Jan 23, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants