Skip to content

Add missing peer map to bpfman volume#1068

Merged
msherif1234 merged 1 commit intonetobserv:mainfrom
msherif1234:latest
Jan 28, 2025
Merged

Add missing peer map to bpfman volume#1068
msherif1234 merged 1 commit intonetobserv:mainfrom
msherif1234:latest

Conversation

@msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jan 28, 2025

Description

add missing peer filter map to ebpf volume

oc get pods -n netobserv-privileged
NAME                         READY   STATUS             RESTARTS      AGE
netobserv-ebpf-agent-dcxwf   0/1     CrashLoopBackOff   1 (8s ago)    44s
netobserv-ebpf-agent-dssls   0/1     CrashLoopBackOff   1 (11s ago)   44s
netobserv-ebpf-agent-jpx58   0/1     CrashLoopBackOff   1 (13s ago)   44s
netobserv-ebpf-agent-pjslk   0/1     CrashLoopBackOff   1 (6s ago)    44s
netobserv-ebpf-agent-q7fzz   0/1     Error              2 (22s ago)   44s
netobserv-ebpf-agent-z7w6m   0/1     Error              2 (28s ago)   44s
oc logs -n netobserv-privileged netobserv-ebpf-agent-dcxwf
time="2025-01-28T15:02:39Z" level=info msg="starting NetObserv eBPF Agent [build version: main-528ec8c, build date: 2025-01-28 12:06]"
time="2025-01-28T15:02:39Z" level=info msg="initializing Flows agent" component=agent.Flows
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading aggregated flows pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading additional flow metrics pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading direct flows pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading DNS flows pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading filter pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=info msg="BPFManager mode: loading Peerfilter pinned maps" component=ebpf.FlowFetcher
time="2025-01-28T15:02:39Z" level=fatal msg="can't instantiate NetObserv eBPF Agent" error="failed to load /run/netobserv/maps/peer_filter_map: no such file or directory"

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 28, 2025
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:18aa0b0
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-18aa0b0
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-18aa0b0

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:18aa0b0 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-18aa0b0

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-18aa0b0
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@msherif1234
Copy link
Contributor Author

oc get bpfapplication
NAME        NODESELECTOR   STATUS             AGE
netobserv   {}             ReconcileSuccess   29s

oc get bpfprograms
NAME                     TYPE          STATUS         AGE
netobserv-tcx-0df72f0c   application   bpfmanLoaded   38s
netobserv-tcx-3628e693   application   bpfmanLoaded   38s
netobserv-tcx-40d429ec   application   bpfmanLoaded   33s
netobserv-tcx-4390e71b   application   bpfmanLoaded   41s
netobserv-tcx-64a804d2   application   bpfmanLoaded   33s
netobserv-tcx-762ac3d1   application   bpfmanLoaded   41s
netobserv-tcx-79d6fe3b   application   bpfmanLoaded   38s
netobserv-tcx-b5e9f7d0   application   bpfmanLoaded   41s
netobserv-tcx-bad388cb   application   bpfmanLoaded   41s
netobserv-tcx-c500c1dd   application   bpfmanLoaded   41s
netobserv-tcx-cff1af2f   application   bpfmanLoaded   41s
netobserv-tcx-f766c7d9   application   bpfmanLoaded   38s

image

image

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234 msherif1234 merged commit 8828735 into netobserv:main Jan 28, 2025
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants