Skip to content

Regenerate doc [1.8 backport]#1126

Merged
jotak merged 2 commits intonetobserv:release-1.8from
jotak:regen-doc-1.8
Feb 11, 2025
Merged

Regenerate doc [1.8 backport]#1126
jotak merged 2 commits intonetobserv:release-1.8from
jotak:regen-doc-1.8

Conversation

@jotak
Copy link
Member

@jotak jotak commented Feb 11, 2025

Backport of #1071

* Regenerate doc

* Add missing cardinality

* Improve docs on newly added features

- bpfman: mention prereq on bpfman operator
- filters: mention important information on default behaviour, how to
  change it, and sampling
- tail filters: mention how they compare with bpf filters
- a few docs style nits
- rename Go field FlowFilterRules=>Rules to match the json name

* doc feedback

* doc feedback
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.42%. Comparing base (0c8fe8c) to head (6764b0c).
Report is 3 commits behind head on release-1.8.

Files with missing lines Patch % Lines
...s/flowcollector/v1beta1/zz_generated.conversion.go 0.00% 2 Missing ⚠️
...pis/flowcollector/v1beta1/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
...pis/flowcollector/v1beta2/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
controllers/ebpf/agent_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #1126      +/-   ##
===============================================
- Coverage        62.65%   62.42%   -0.24%     
===============================================
  Files               77       77              
  Lines            11581    11581              
===============================================
- Hits              7256     7229      -27     
- Misses            3872     3893      +21     
- Partials           453      459       +6     
Flag Coverage Δ
unittests 62.42% <20.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apis/flowcollector/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
apis/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
...lector/v1beta2/flowcollector_validation_webhook.go 70.55% <100.00%> (ø)
apis/flowmetrics/v1alpha1/flowmetric_types.go 100.00% <ø> (ø)
...s/flowcollector/v1beta1/zz_generated.conversion.go 33.09% <0.00%> (ø)
...pis/flowcollector/v1beta1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...pis/flowcollector/v1beta2/zz_generated.deepcopy.go 39.58% <0.00%> (ø)
controllers/ebpf/agent_controller.go 45.96% <0.00%> (ø)

... and 6 files with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@jotak jotak merged commit 2950b95 into netobserv:release-1.8 Feb 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants