Skip to content

feat(KONFLUX-4158): add fbc-fips-check task to FBC pipeline#1166

Merged
jotak merged 4 commits intonetobserv:mainfrom
jotak:fbc-fips
Feb 18, 2025
Merged

feat(KONFLUX-4158): add fbc-fips-check task to FBC pipeline#1166
jotak merged 4 commits intonetobserv:mainfrom
jotak:fbc-fips

Conversation

@jotak
Copy link
Member

@jotak jotak commented Feb 18, 2025

This commit adds the fbc-fips-check to the FBC pipeline. It also adds a template file named images-mirror-set.yaml which is required by the FIPS task itself and will be used by other tasks in the future.

Signed-off-by: yashvardhannanavati 22090997+yashvardhannanavati@users.noreply.github.com

Update .tekton/images-mirror-set.yaml

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

This commit adds the fbc-fips-check to the FBC pipeline.
It also adds a template file named images-mirror-set.yaml which is required by
the FIPS task itself and will be used by other tasks in the future.

Signed-off-by: yashvardhannanavati <22090997+yashvardhannanavati@users.noreply.github.com>

Update .tekton/images-mirror-set.yaml
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member Author

jotak commented Feb 18, 2025

cherry-picked from #1163

@jotak jotak requested a review from OlivierCazade February 18, 2025 09:38
@jotak
Copy link
Member Author

jotak commented Feb 18, 2025

Hi @yashvardhannanavati
After cherry-picked your commit on main, I can see that the fips check passes here: https://console.redhat.com/application-pipeline/workspaces/ocp-network-observab/applications/fbc-v4-16/pipelineruns/fbc-v4-16-on-pull-request-xjwmh/logs?task=fbc-fips-check-oci-ta
However, it seems to only check for a single related image; there should be 4 related images - is that expected, or something wrong on our side?

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.39%. Comparing base (9384dd2) to head (373505b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   62.40%   62.39%   -0.01%     
==========================================
  Files          77       77              
  Lines       11581    11581              
==========================================
- Hits         7227     7226       -1     
+ Misses       3896     3895       -1     
- Partials      458      460       +2     
Flag Coverage Δ
unittests 62.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm label Feb 18, 2025
@jotak jotak merged commit 33e2fdf into netobserv:main Feb 18, 2025
24 of 25 checks passed
jotak added a commit that referenced this pull request Feb 18, 2025
* feat(KONFLUX-4158): add fbc-fips-check task to FBC pipeline

This commit adds the fbc-fips-check to the FBC pipeline.
It also adds a template file named images-mirror-set.yaml which is required by
the FIPS task itself and will be used by other tasks in the future.

Signed-off-by: yashvardhannanavati <22090997+yashvardhannanavati@users.noreply.github.com>

Update .tekton/images-mirror-set.yaml

* add related images

* update patch_catalog.py

* Keep related images

---------

Co-authored-by: yashvardhannanavati <22090997+yashvardhannanavati@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants