Skip to content

Expose openssl feature#2398

Draft
jpinsonneau wants to merge 1 commit intonetobserv:mainfrom
jpinsonneau:openssl_feature
Draft

Expose openssl feature#2398
jpinsonneau wants to merge 1 commit intonetobserv:mainfrom
jpinsonneau:openssl_feature

Conversation

@jpinsonneau
Copy link
Member

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau requested a review from jotak February 2, 2026 10:17
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 2.47934% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.49%. Comparing base (5b9cf16) to head (7fc10fb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/ebpf/bpfmanager-controller.go 0.00% 113 Missing ⚠️
internal/controller/ebpf/agent_controller.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   72.01%   71.49%   -0.52%     
==========================================
  Files          93       93              
  Lines       10501    10542      +41     
==========================================
- Hits         7562     7537      -25     
- Misses       2464     2523      +59     
- Partials      475      482       +7     
Flag Coverage Δ
unittests 71.49% <2.47%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
...lector/v1beta2/flowcollector_validation_webhook.go 72.29% <ø> (ø)
api/flowcollector/v1beta2/helper.go 83.05% <100.00%> (+0.29%) ⬆️
internal/controller/ebpf/agent_controller.go 60.34% <16.66%> (-0.52%) ⬇️
internal/controller/ebpf/bpfmanager-controller.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant