NETOBSERV-1981: Fix Exporters form view

[Amoghrd]

Description

Fix form view for exporters section

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-1981 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

Fix form view for exporters section

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jpinsonneau]

Code looks good, did you give a try ?

[Amoghrd]

nope not yet. Will try it now

[Amoghrd]

Do the changes to files other than the CSV look good?

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:52cc70c
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-52cc70c
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-52cc70c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:52cc70c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-52cc70c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-52cc70c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:cf05dd6
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cf05dd6
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cf05dd6

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:cf05dd6 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cf05dd6

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cf05dd6
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

OpenTelemtry does not show up as default now but I dont see the sub fields for any of the exporters so there is still something missing

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:19d5070
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-19d5070
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-19d5070

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:19d5070 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-19d5070

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-19d5070
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:93dda85
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-93dda85
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-93dda85

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:93dda85 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-93dda85

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-93dda85
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

@jotak The exporters view is still not fixed with latest changes and still facing the issue mentioned here

[jotak]

@Amoghrd I rebased and fixed the bad generated names issue, can you check if this is still good for you?

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:b01b2a1
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b01b2a1
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b01b2a1

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:b01b2a1 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-b01b2a1

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-b01b2a1
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[jpinsonneau]

are we good to merge this ?

[Amoghrd]

I have attached the screen-recording of the issue I am still facing on the JIRA. I am not able to figure out how to fix that. If that will be fixed at a later stage then this PR can be merged to fix just the view

[jpinsonneau]

targetHost & targetPort fields are mandatory in both FlowCollectorIPFIXReceiver & FlowCollectorOpenTelemetry.

• targetHost is not triggering an error since it defaults to an empty string
  

  network-observability-operator/api/v1beta2/flowcollector_types.go

  Lines 269 to 271 in 5fa0717

  	//+kubebuilder:default:=""
  	// Address of the IPFIX external receiver
  	TargetHost string `json:"targetHost"`

• targetPort is triggering an error since it's not defaulting any value
  

  network-observability-operator/api/v1beta2/flowcollector_types.go

  Lines 273 to 274 in 5fa0717

  	// Port for the IPFIX external receiver
  	TargetPort int `json:"targetPort"`

So adding defaults to these ports should make the trick here 😸
Use 4739 for IPFIX and 4317 for otel

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:0c6a359
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-0c6a359
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-0c6a359

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:0c6a359 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-0c6a359

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-0c6a359
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

Okay, that helped and I dont see the error now. Thanks @jpinsonneau
This can be merged if code looks good

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-1981 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

Fix form view for exporters section

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Amoghrd]

/retest

[jpinsonneau]

Code looks good, feel free to merge when all the tests pass 😉

Thanks @Amoghrd !

[Amoghrd]

Only Konflux check is failing. Will merge the PR
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment