Skip to content

Improve for overloaded methods #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hnx8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve for overloaded methods #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion MarkdownGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,15 @@ void BuildTable<T>(MarkdownBuilder mb, string label, T[] array, IEnumerable<XmlD

var data = seq.Select(item2 =>
{
var summary = docs.FirstOrDefault(x => x.MemberName == name(item2) || x.MemberName.StartsWith(name(item2) + "`"))?.Summary ?? "";
var candidates = docs.Where(x => x.MemberName == name(item2) || x.MemberName.StartsWith(name(item2) + "`")).ToArray();
if (candidates.Count() >= 2 && item2 is MethodBase)
{
// Attempt to identify method overloads
var methodParameterNames = (item2 as MethodBase).GetParameters().Select(p => p.Name);
var overloadCandidates = candidates.Where(x => x.Parameters.Keys.SequenceEqual(methodParameterNames)).ToArray();
if (overloadCandidates.Any()) { candidates = overloadCandidates; }
}
var summary = candidates.FirstOrDefault()?.Summary ?? "";
return new[] { MarkdownBuilder.MarkdownCodeQuote(type(item2)), finalName(item2), summary };
});

Expand Down