Extend datatypes in python API and TUI#461
Merged
JoeZiminski merged 26 commits intomainfrom Feb 21, 2025
Merged
Conversation
e9b82e0 to
4550a4f
Compare
JoeZiminski
commented
Feb 18, 2025
JoeZiminski
commented
Feb 18, 2025
for more information, see https://pre-commit.ci
07df398 to
1058d43
Compare
|
I tested both the TUI and the Python API (from a Python console started in the terminal). I have a couple of suggestions/observations:
|
viktorpm
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose all 'Narrow' datatypes from Neuroblueprint. This basically extends the allowed datatype names (e.g.
ephysis broad,icephysis narrow).This PR adds:
canonical_configswhich match the neuroblueprint narrow datatypesIn NeuroBlueprint, it is not allowed to mix broad and narrow datatypes. This is not validated in this PR, but will be added to #464.
How to test
TUI
In the TUI, on the 'Create Folders' tab and 'Transfer' (Custom) tab there is a new button 'Displayed datatypes'. Clicking this will open a new window where you can select which datatype checkboxes to display. It will be good to know a) this works as expected b) is intuitive to use. Which checkboxes are displayed and their status should be saved across
datashuttlesessions.Python API
You can try creating folders like:
You could also try adding a file to the "cscope" folder and doing something like: