Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes #617) #681
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…euroinformatics-unit#617) Updated keyboard shortcut tooltips in tooltips.py to emphasize CTRL+C (with SHIFT) instead of CTRL+Q for copying filepath to clipboard. CTRL+Q quits the application on macOS, so CTRL+C is the more appropriate shortcut for users on that platform.
for more information, see https://pre-commit.ci
Add module docstring for custom exceptions.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR
Why is this PR needed?
Issue #617 reported that the CTRL+Q keyboard shortcut tooltip is problematic on macOS because CTRL+Q quits the application on that platform. This PR updates the tooltip to emphasize CTRL+C (with SHIFT) instead, which is the correct way to copy the highlighted file path to the clipboard.
What does this PR do?
Updates keyboard shortcut tooltips in
datashuttle/tui/tooltips.pyto clarify that users should use CTRL+C with SHIFT to copy the filepath to the clipboard. This avoids the accidental application quit on macOS when users press CTRL+Q.