Add type hints to test_unit.py test methods (#532) #683
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…euroinformatics-unit#617) Updated keyboard shortcut tooltips in tooltips.py to emphasize CTRL+C (with SHIFT) instead of CTRL+Q for copying filepath to clipboard. CTRL+Q quits the application on macOS, so CTRL+C is the more appropriate shortcut for users on that platform.
for more information, see https://pre-commit.ci
Add module docstring for custom exceptions.
for more information, see https://pre-commit.ci
- Add return type hints (-> None) to test methods in test_unit.py - Specifically: test_datetime_string_replacement and test_process_to_keyword_in_sub_input - Part of issue neuroinformatics-unit#532 effort to extend type hints to test files
AdityaGupta716
commented
Feb 9, 2026
| "key", [tags("date"), tags("time"), tags("datetime")] | ||
| ) | ||
| def test_datetime_string_replacement(self, key, underscore_position): | ||
| def test_datetime_string_replacement(self, key, underscore_position): -> None: |
Author
There was a problem hiding this comment.
Syntax error: The return type hint should come before the colon, not after it.
Should be: def test_datetime_string_replacement(self, key, underscore_position) -> None:
Not: def test_datetime_string_replacement(self, key, underscore_position): -> None:
This is causing the pre-commit.ci check to fail with a SyntaxError.
|
|
||
| @pytest.mark.parametrize("prefix", ["sub", "ses"]) | ||
| def test_process_to_keyword_in_sub_input(self, prefix): | ||
| def test_process_to_keyword_in_sub_input(self, prefix): -> None: |
Author
There was a problem hiding this comment.
Same syntax error here. The return type hint should come before the colon.
Should be: def test_process_to_keyword_in_sub_input(self, prefix) -> None:
Not: def test_process_to_keyword_in_sub_input(self, prefix): -> None:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues to add type hints to test files as described in issue #532. This PR focuses on adding return type hints to test methods in test_unit.py.
What is this PR?
Why is this PR needed?
Continuing the effort to extend type hints to test files to improve code readability and enable better IDE support.
What does this PR do?
References
Part of #532
How has this PR been tested?