Skip to content

Conversation

@AleTorrisi
Copy link

Proposed changes

This PR works in combination with newfold-labs/wp-module-performance#135 for Performance module.
The goal is delegate everything to that module and remove useless code in the brand plugin.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@cypress
Copy link

cypress bot commented Mar 21, 2025

Web Plugin    Run #1241

Run Properties:  status check failed Failed #1241  •  git commit 392b80df19 ℹ️: Merge 1eb795a89b83a5b3afb219c394d9b4e35739cda0 into 85a6afc3498a5da21b4fbd7298dd...
Project Web Plugin
Branch Review support-for-cache-refactoring
Run status status check failed Failed #1241
Run duration 04m 40s
Commit git commit 392b80df19 ℹ️: Merge 1eb795a89b83a5b3afb219c394d9b4e35739cda0 into 85a6afc3498a5da21b4fbd7298dd...
Committer Alessio Torrisi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 61
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-performance/tests/cypress/integration/performance.cy.js • 1 failed test

View Output Video

Test Artifacts
Performance Page > Clear Cache Button Functions Screenshots Video
Flakiness  tests/cypress/integration/help.cy.js • 1 flaky test

View Output Video

Test Artifacts
Help Page > Is Accessible Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants