fix(share): icons

[alperozturk96]

• Tests written, or not not needed

Fixes

Share internal link alignment
Dropdown icon visibility (only visible if permission name exists)
Converts image views to material icon button since they are button not icon

Before Internal Dark	After Internal Dark

Before Internal Light	After Internal Light

Before External Light	After External Light

Before External Dark	After External Dark

[AndyScherzinger]

@alperozturk96 What is the webUI displaying? Is it also hiding the element or are we missing something on the client-side?

[AndyScherzinger]

@alperozturk96 the icon colors changed, but didn't yet check what M3 would define for icon-only buttons

[alperozturk96]

/backport to stable-3.36

[alperozturk96]

Before

After

[alperozturk96]

@alperozturk96 the icon colors changed, but didn't yet check what M3 would define for icon-only buttons

Maybe this app:iconTint="?attr/colorOnSurfaceVariant" ?

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16418.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[AndyScherzinger]

If you want a declarative way, current you'd need to set up the Grey color we defined, afaik #666666

The material color is dynamic, so you'd need to call a theming util function for that.

Switching to colorOnSurfaceVariant would force you to change that everywhere in the UI so I wouldn't not do it in this PR but just make the changed one Grey again.